Add version comparison #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2016 09:34
This updates the package tar name to x86_64 for versions 4.6.0 and above since Elastic updated this on their end.
|
+1 |
|
+1 :) |
|
+1 ! |
|
+1 |
1 similar comment
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the install manifest to update the architecture portion of the tar file based on the version of kibana being installed.
At 4.6.0 elastic started using the normal x86_64 extension instead of just x64.
Should also note that the base_url for later versions needs to be updated to https://artifacts.elastic.co/downloads/kibana as well, but since this is in params and can be overridden in the class instantiation, I left this as is with the default at 4.0.1. When you update that default version, should update the base_url to reflect as well.